Skip to content

TST Adapts wminkowski for scipy 1.6.0 #19096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 5, 2021
Merged

TST Adapts wminkowski for scipy 1.6.0 #19096

merged 9 commits into from
Jan 5, 2021

Conversation

thomasjpfan
Copy link
Member

Since wminkowski is deprecated in scipy 1.6.0, this PR skips those tests when scipy >= 1.6.0

@lorentzenchr
Copy link
Member

Should we skip those tests or replace the use of scipy.distance.wminkowski with scipy.distance.minkowski and w keyword as advised in the 1.6.0 release notes?
https://docs.scipy.org/doc/scipy-1.6.0/reference/release.1.6.0.html#scipy-spatial-changes

@thomasjpfan thomasjpfan marked this pull request as draft January 3, 2021 16:59
@cmarmo cmarmo mentioned this pull request Jan 4, 2021
Closed
@thomasjpfan thomasjpfan marked this pull request as ready for review January 4, 2021 14:49
@thomasjpfan thomasjpfan changed the title TST Skip tests that fail for scipy 1.6.0 from wminkowski TST Adapts wminkowski for scipy 1.6.0 Jan 4, 2021
glemaitre
glemaitre reviewed Jan 4, 2021
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups I forgot to post my comments.

@amidvidy amidvidy mentioned this pull request Jan 5, 2021
Merged
ogrisel
ogrisel approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@glemaitre glemaitre merged commit ef4e95f into scikit-learn:master Jan 5, 2021
@glemaitre
Copy link
Member

Thanks @thomasjpfan. Let see if we will get some green CIs :)

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jan 19, 2021
@thomasjpfan @glemaitre
TST Adapts wminkowski for scipy 1.6.0 (scikit-learn#19096)
eee3918
jeremiedbb pushed a commit that referenced this pull request Jan 19, 2021
@thomasjpfan @jeremiedbb
TST Adapts wminkowski for scipy 1.6.0 (#19096)
802b76d
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
module:neighbors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @lorentzenchr @glemaitre @ogrisel