Skip to content

TST explicit convert array to float that will contains np.nan #19101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

TST explicit convert array to float that will contains np.nan #19101

merged 1 commit into from
Jan 4, 2021

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Jan 4, 2021 •
edited
Loading

np.pad was called on an integer array and padded with np.nan. An implicit casting to np.float64 was performed and is not longer allowed in NumPy master.

thomasjpfan
thomasjpfan approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, failing test is unrelated and should be resolved with #19096

@thomasjpfan thomasjpfan merged commit e325bf7 into scikit-learn:master Jan 4, 2021
@rmcgibbo rmcgibbo mentioned this pull request Feb 3, 2021
Merged
ogrisel pushed a commit that referenced this pull request Feb 3, 2021
@glemaitre @ogrisel
TST explicit convert array to float that will contains np.nan (#19101)
11a7a68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glemaitre @thomasjpfan