[MRG] Ensure delegated ducktyping in MetaEstimators #2019
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tests passing, fixing #1805 for:
I do not know of other implemented metaestimators where this type of ducktyping delegation should occur. So please come forth and review! |
|
this needs further discussion before it can be merged. retagging 0.15 :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to solve #1805, ensuring that appropriate metaestimators have
hasattr(metaest, method) == Trueiff the sub-estimator does for the set of standard methods:inverse_transform,transform,predict,predict_proba,predict_log_proba,decision_function,score.I posted this as a WIP so that you can:
I currently take the approach of testing for attributes only after fitting. There may be problems if ducktyping is used before fitting on, say, a
GridSearchCV, but I guess that's just something we'll have to be aware of when working with ducktyping.I also am not currently dealing with metaestimators that delegate their
fitmethods. (I'm not sure if they exist, but I have considered some.)(I have pulled in the relevant commit from #1769 and removed its Pipeline-particular testing.)