Skip to content

TST solve issues in PyPy #20978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2021
Merged

TST solve issues in PyPy #20978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b56252e
TST fix brittle test in pypy for error message
glemaitre Sep 8, 2021
32efd06
iter
glemaitre Sep 8, 2021
7eba17a
Update test_sgd.py
glemaitre Sep 8, 2021
eda144c
Update test_sgd.py
glemaitre Sep 8, 2021
8476a6b
remove pypy3 in PRs
glemaitre Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,6 @@ workflows:
- doc-min-dependencies:
requires:
- lint
- pypy3:
filters:
branches:
only:
- 0.20.X
- deploy:
requires:
- doc
Expand Down
2 changes: 1 addition & 1 deletion sklearn/linear_model/tests/test_sgd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def test_sgd_estimator_params_validation(klass, fit_method, params, err_msg):
try:
sgd_estimator = klass(**params)
except TypeError as err:
if "__init__() got an unexpected keyword argument" in str(err):
if "unexpected keyword argument" in str(err):
# skip test if the parameter is not supported by the estimator
return
raise err
Expand Down