Skip to content

MNT Remove obsolete code (Python >= 3.7) #21092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2021
Merged

MNT Remove obsolete code (Python >= 3.7) #21092

merged 2 commits into from
Sep 20, 2021

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 20, 2021 •
edited
Loading

What does this implement/fix? Explain your changes.

Remove obsolete code:

  • No need to import division / print_function from __future__ in Python 3
  • Remove backport of PEP 562 for Python >= 3.7

@DimitriPapadopoulos DimitriPapadopoulos changed the title Remove obsolete code - Python >= 3.7 Remove obsolete code (Python >= 3.7) Sep 20, 2021
thomasjpfan
thomasjpfan approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @DimitriPapadopoulos !

LGTM

@glemaitre glemaitre changed the title Remove obsolete code (Python >= 3.7) MNT Remove obsolete code (Python >= 3.7) Sep 20, 2021
@glemaitre glemaitre merged commit 6c068e2 into scikit-learn:main Sep 20, 2021
@glemaitre
Copy link
Member

Thanks @DimitriPapadopoulos. All the CIs are aline with Python >=3.7

@DimitriPapadopoulos DimitriPapadopoulos deleted the __future__ branch September 21, 2021 05:15
lorentzenchr
lorentzenchr reviewed Sep 21, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan mentioned this pull request Sep 22, 2021
Merged
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Sep 26, 2021
Closed
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
Merged
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
@DimitriPapadopoulos @glemaitre
MNT Remove obsolete code (Python >= 3.7) (scikit-learn#21092)
5bd10d2
glemaitre pushed a commit that referenced this pull request Oct 25, 2021
@DimitriPapadopoulos @glemaitre
MNT Remove obsolete code (Python >= 3.7) (#21092)
a8b7c59
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@DimitriPapadopoulos @samronsin
MNT Remove obsolete code (Python >= 3.7) (scikit-learn#21092)
9cbb1a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentzenchr lorentzenchr lorentzenchr left review comments

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:impute module:neighbors No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DimitriPapadopoulos @glemaitre @thomasjpfan @lorentzenchr