Skip to content

DOC Ensures that IterativeImputer passes numpydoc validation #21108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 28, 2021
Merged

DOC Ensures that IterativeImputer passes numpydoc validation #21108

merged 5 commits into from
Sep 28, 2021

Conversation

jmloyola
Copy link
Member

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensures IterativeImputer is compatible with numpydoc:

  • Remove IterativeImputer from DOCSTRING_IGNORE_LIST.
  • Verify that all tests are passing.
  • Change docstrings to maintain consistency.

glemaitre
glemaitre approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

jmloyola and others added 2 commits September 23, 2021 16:15
@jmloyola @glemaitre
Apply reviewers suggestions
057d083 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@jmloyola
Merge main into fix_numpydoc_iterativeimputer
e483a11
ogrisel
ogrisel approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Let me re-run the failed CI jobs as it should be unrelated to this PR and probably random (failing pip install command).

@jmloyola
Copy link
Member Author

Thanks for the review @glemaitre and @ogrisel. I think this PR is ready to be merged, unless you think there is something else to be done, in which case, I'll happily work through it 🤓 .

@glemaitre glemaitre merged commit 20509fb into scikit-learn:main Sep 28, 2021
@glemaitre
Copy link
Member

Thanks @jmloyola Nice improvement

@jmloyola jmloyola deleted the fix_numpydoc_iterativeimputer branch September 28, 2021 19:24
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
Merged
10 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
@jmloyola @glemaitre
DOC Ensures that IterativeImputer passes numpydoc validation (scikit-…
f5dd73f 
…learn#21108)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Oct 25, 2021
@jmloyola @glemaitre
DOC Ensures that IterativeImputer passes numpydoc validation (#21108)
88398ef 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@jmloyola @glemaitre @samronsin
DOC Ensures that IterativeImputer passes numpydoc validation (scikit-…
fd37cc9 
…learn#21108)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation module:impute
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmloyola @glemaitre @ogrisel