Skip to content

DOC Typo in 1.0.0 release highlights #21126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Sep 23, 2021

Also the what's new / changelog does not currently linlk to those. Shall I fix this as part of this PR?

@ogrisel ogrisel added this to the 1.0 milestone Sep 23, 2021
@thomasjpfan
Copy link
Member

Shall I fix this as part of this PR?

Okay let's fix it here.

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's new now links to the highlights

@ogrisel ogrisel force-pushed the fix-release-highlights branch from ab40479 to ecaac92 Compare September 23, 2021 14:43
@ogrisel ogrisel force-pushed the fix-release-highlights branch from ecaac92 to 959e97d Compare September 23, 2021 14:44
@adrinjalali
Copy link
Member

feel free to merge @ogrisel

@ogrisel
Copy link
Member Author

ogrisel commented Sep 23, 2021

Ok I removed the redundant linking from whats_new/v1.0rst.

@thomasjpfan thomasjpfan changed the title Typo in 1.0.0 release highlights DOC Typo in 1.0.0 release highlights Sep 23, 2021
@ogrisel ogrisel merged commit 05d470d into scikit-learn:main Sep 23, 2021
@ogrisel
Copy link
Member Author

ogrisel commented Sep 23, 2021

Done!

@ogrisel ogrisel deleted the fix-release-highlights branch September 23, 2021 14:48
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Sep 23, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants