Skip to content

DOC correct the type of estimator attributes in RandomTreeEmbedding #21141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

glemaitre
Copy link
Member

closes #21140

We do not properly document the type of base_estimator_ and estimators_ in RandomTreeEmbedding

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan added this to the 1.0.1 milestone Sep 24, 2021
@thomasjpfan thomasjpfan merged commit 28567a5 into scikit-learn:main Sep 24, 2021
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type for RandomTreeEmbedding.base_estimator_ in the documentation
2 participants