MAINT Copy latest version of file from upstream #21163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08fbb5c to
e6b1d82
Compare
Actually scipy/sparse/linalg/eigen/lobpcg/lobpcg.py has not been removed from SciPy 1.3.0 (or even current 1.7.1).
e6b1d82 to
740c944
Compare
|
LGTM. Thanks. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
glemaitre
pushed a commit
that referenced
this pull request
Oct 25, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also #21161.
What does this implement/fix? Explain your changes.
Copied from
scipy/sparse/linalg/eigen/lobpcg/lobpcg.py@a612462.Actuallyscipy/sparse/linalg/eigen/lobpcg/lobpcg.pyhas not been removed from SciPy 1.3.0 (or even current 1.7.1).Any other comments?
We should clarify the situation of this file upstream. Is it deprecated? Will it be removed? Why hasn't it be removed from SciPy 1.3.0?