DOC minor updates to release process #21172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Sep 28, 2021
glemaitre
approved these changes
Sep 28, 2021
| @@ -211,6 +211,12 @@ Making a release | |||
|
|
|||
| https://github.com/scikit-learn/scikit-learn/actions?query=workflow%3A%22Publish+to+Pypi%22 | |||
|
|
|||
| 4.1 You can test the conda-forge builds by submitting a PR to the feedstock | |||
| repo: https://github.com/conda-forge/scikit-learn-feedstock. If you want to | |||
| publish an RC release on conda-forge, the PR should target the `rc` branch | |||
There was a problem hiding this comment.
Could we make it in bold regarding the rc branch. I think this is something that could be easily overlooked.
There was a problem hiding this comment.
I personally don't check a rendered version of this doc, so I'm not sure making it bold would help.
|
Let's merge as-is. It anyway a great improvement. |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Oct 25, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the release process, a few minor changes according to my latest experience.