Skip to content

Use merge=union strategy for all version changelogs #21235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Oct 4, 2021

Reference Issues/PRs

It was done originally in #7896 but was not updated when we split the whats_new.rst into version-specific files.

What does this implement/fix? Explain your changes.

This should avoid most conflicts due to changelog changes. I noticed quite a few of them recently in PRs I was following.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @lesteve !

Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
@ogrisel ogrisel merged commit e15d941 into scikit-learn:main Oct 5, 2021
@lesteve lesteve deleted the merge-union-for-changelogs branch October 8, 2021 14:04
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021

Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
glemaitre pushed a commit that referenced this pull request Oct 25, 2021

Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021

Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants