DOC Ensures that TransformedTargetRegressor passes numpydoc validation #21261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Yes, it is not obvious which other estimator we should link to. I was thinking that we could provide an entry for FunctionTransformer. It would a counterpart where you can modify |
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
Thanks for answering @glemaitre 🤓 |
|
Thanks @jmloyola LGTM |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
scikit-learn#21261) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Oct 25, 2021
#21261) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
scikit-learn#21261) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
scikit-learn#21261) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
This PR ensures TransformedTargetRegressor is compatible with numpydoc:
TransformedTargetRegressorfromDOCSTRING_IGNORE_LIST.Any other comments?
This is work in progress because there still remains a failing test. The class docstring does not have a
See Alsosection. I didn't know what to include there. @thomasjpfan, @glemaitre, what do you think we can add here?