Skip to content

DOC Ensures that LocallyLinearEmbedding passes numpydoc validation #21273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

baam25simo
Copy link
Contributor

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

  • LocallyLinearEmbedding removed from DOCSTRING_IGNORE_LIST in test_docstrings.py
  • In LocallyLinearEmbedding.__init__: "See Also" section added and minor fixes.
  • In LocallyLinearEmbedding.fit: y and return descriptions added.
  • In LocallyLinearEmbedding.fit_transform: return description added.
  • In LocallyLinearEmbedding.transform: X and return descriptions added.

@glemaitre glemaitre self-requested a review October 21, 2021 09:36
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I resolve the conflicts and took the opportunity to itemize the solver choices. Let's wait for the documentation CI to finish before merging.

@glemaitre glemaitre merged commit eb6e35e into scikit-learn:main Oct 21, 2021
@glemaitre
Copy link
Member

All good. Thanks @baam25simo

@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
glemaitre added a commit that referenced this pull request Oct 25, 2021
…21273)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants