Skip to content

MAINT Fix Check Manifest in CI #21317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

MAINT Fix Check Manifest in CI #21317

merged 1 commit into from
Oct 13, 2021

Conversation

DimitriPapadopoulos
Copy link
Contributor

What does this implement/fix? Explain your changes.

Hopefully this will fix the error in the Check Manifest GitHub action.

Any other comments?

▼ Run check-manifest -v
  check-manifest -v
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.9.7/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.7/x64/lib
lists of files in version control and sdist do not match!
missing from sdist:
  .git-blame-ignore-revs
listing source files under version control: 1301 files and directories
building an sdist: scikit-learn-1.1.dev0.tar.gz: 1300 files and directories
copying source files to a temporary directory
building a clean sdist: scikit-learn-1.1.dev0.tar.gz: 1300 files and directories
Error: Process completed with exit code 1.

thomasjpfan
thomasjpfan approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @DimitriPapadopoulos !

I checked this locally and it passes check-manifest. LGTM

@thomasjpfan thomasjpfan merged commit 0379747 into scikit-learn:main Oct 13, 2021
@DimitriPapadopoulos DimitriPapadopoulos deleted the MANIFEST branch October 13, 2021 18:35
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
Merged
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
@DimitriPapadopoulos @glemaitre
MAINT Fix Check Manifest in CI (scikit-learn#21317)
45c651b
glemaitre pushed a commit that referenced this pull request Oct 25, 2021
@DimitriPapadopoulos @glemaitre
MAINT Fix Check Manifest in CI (#21317)
66fee5f
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@DimitriPapadopoulos @samronsin
MAINT Fix Check Manifest in CI (scikit-learn#21317)
313bf04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @thomasjpfan