Skip to content

FIX set docstrings on sklearn.utils.fixes.threadpool_limits/info #21338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Oct 15, 2021

Try to fix a CI failure caused by the recent merge of two unrelated but interacting PRs.

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre
Copy link
Member

ping @adrinjalali

@adrinjalali
Copy link
Member

adrinjalali commented Oct 15, 2021

O_o now the question is why are the tests passing in the mkl latest env here

@adrinjalali adrinjalali merged commit 47a49c5 into scikit-learn:main Oct 15, 2021
@ogrisel ogrisel deleted the threadpool_info_limits_docstring branch October 15, 2021 11:38
@thomasjpfan
Copy link
Member

Should sklearn.util.fixes be considered part of the public API and pass numpydoc validation? They are not documented in doc/modules/classes.rst.

@adrinjalali
Copy link
Member

that's what I thought, but I figured that'd be a separate PR to fix that.

@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
…kit-learn#21338)

* FIX set docstrings on sklearn.utils.fixes.threadpool_limits/info

* Skip threadpool_info/threadpool_limits docstring checks for now
glemaitre pushed a commit that referenced this pull request Oct 25, 2021
)

* FIX set docstrings on sklearn.utils.fixes.threadpool_limits/info

* Skip threadpool_info/threadpool_limits docstring checks for now
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…kit-learn#21338)

* FIX set docstrings on sklearn.utils.fixes.threadpool_limits/info

* Skip threadpool_info/threadpool_limits docstring checks for now
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
…kit-learn#21338)

* FIX set docstrings on sklearn.utils.fixes.threadpool_limits/info

* Skip threadpool_info/threadpool_limits docstring checks for now
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
)

* FIX set docstrings on sklearn.utils.fixes.threadpool_limits/info

* Skip threadpool_info/threadpool_limits docstring checks for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants