DOC improve build instructions to be friendlier to first time contributors #21353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Oct 16, 2021
thomasjpfan
approved these changes
Oct 16, 2021
|
Rendering looks good. Merging. |
|
I'm a little confused with the docs. But, my process would be to first go to "Contributing Guide" here: But, the instructions for building from source are ("buried") in Step 5:
The "Building from Source" are the instructions that @amueller has been showing at the sprints, and what has worked, but are not very prominent. Can we add a section: Building from Source
====================and point it to: https://scikit-learn.org/dev/developers/index.html |
|
Thanks for the feedback @reshamas. I agree. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
glemaitre
pushed a commit
that referenced
this pull request
Oct 25, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the feedback of today's Data Umbrella sprint install session, I thought we can further improve our setup instructions:
wheelpackage is not automatically installed in newly created virtualenvCosmetic: I also tried to use more consistent indentation levels in the bash prompts.
/cc @reshamas