Skip to content

MAINT pin python version for source tarball builder [cd build] #21386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

MAINT pin python version for source tarball builder [cd build] #21386

merged 1 commit into from
Oct 21, 2021

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Oct 21, 2021

This should fix the broken [cd build] workflow.

Assuming the fix works as intended, I think we will need to include it in 1.0.X to release 1.0.1.

@ogrisel ogrisel added this to the 1.0.1 milestone Oct 21, 2021
thomasjpfan
thomasjpfan approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 99f2dde into scikit-learn:main Oct 21, 2021
@thomasjpfan
Copy link
Member

Travis CI build failure is unrelated. Merging.

@ogrisel ogrisel deleted the maint-tarball-builder branch October 21, 2021 15:15
@ogrisel ogrisel added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Oct 21, 2021
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
Merged
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
@ogrisel @glemaitre
MAINT pin python version for source tarball builder [cd build] (sciki…
549081a 
…t-learn#21386)
glemaitre pushed a commit that referenced this pull request Oct 25, 2021
@ogrisel @glemaitre
MAINT pin python version for source tarball builder [cd build] (#21386)
bda5343
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@ogrisel @samronsin
MAINT pin python version for source tarball builder [cd build] (sciki…
780221a 
…t-learn#21386)
@lesteve lesteve mentioned this pull request Apr 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Build / CI To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ogrisel @thomasjpfan