Skip to content

MAINT XFAIL test_linear_model_normalize_deprecation_message on macos #21396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Oct 22, 2021

Fixes #21395 (temporary workaround as long as we support numpy < 1.22).

@ogrisel ogrisel added No Changelog Needed To backport PR merged in master that need a backport to a release branch defined based on the milestone. labels Oct 22, 2021
@ogrisel ogrisel changed the title XFAIL test_linear_model_normalize_deprecation_message on macos MAINT XFAIL test_linear_model_normalize_deprecation_message on macos Oct 22, 2021
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel ogrisel added this to the 1.0.1 milestone Oct 22, 2021
@ogrisel
Copy link
Member Author

ogrisel commented Oct 22, 2021

Let's merge this quick workaround to get the CI back to green in PRs.

@ogrisel ogrisel merged commit 1a7eec8 into scikit-learn:main Oct 22, 2021
@ogrisel ogrisel deleted the workaround-macos-clang-numpy-warnings branch October 22, 2021 11:08
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:linear_model No Changelog Needed To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeWarning "invalid value encountered in reciprocal" when running tests on macOS
2 participants