Skip to content

Follow-up fix for check_classifiers_train on prescott OpenBLAS #21704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2021
Merged

Follow-up fix for check_classifiers_train on prescott OpenBLAS #21704

merged 1 commit into from
Nov 18, 2021

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 18, 2021

Addresses the problem seen in: #21702 (comment)

@ogrisel
Copy link
Member Author

ogrisel commented Nov 18, 2021

We could improve create_memmap_backed_data to do that automatically but I was too lazy. The real fix will be to fix joblib anyways.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 18, 2021 •
edited
Loading

BTW I test it on an Intel machine and it works as expected:

$ OPENBLAS_CORETYPE=Prescott pytest -v sklearn/tests/test_common.py -k "check_classifiers_train and svc"                                                                                              
================================================= test session starts =================================================
platform linux -- Python 3.10.0, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /storage/store/work/ogrisel/mambaforge/envs/d
ev/bin/python3.10                                                                                                      
cachedir: .pytest_cache
rootdir: /home/parietal/ogrisel/code/scikit-learn, configfile: setup.cfg
collected 8785 items / 8776 deselected / 9 selected                                                                   

sklearn/tests/test_common.py::test_estimators[LinearSVC()-check_classifiers_train] PASSED                       [ 11%]
sklearn/tests/test_common.py::test_estimators[LinearSVC()-check_classifiers_train(readonly_memmap=True)] PASSED [ 22%]
sklearn/tests/test_common.py::test_estimators[LinearSVC()-check_classifiers_train(readonly_memmap=True,X_dtype=float32$] PASSED [ 33%]
sklearn/tests/test_common.py::test_estimators[NuSVC()-check_classifiers_train] PASSED                           [ 44%]
sklearn/tests/test_common.py::test_estimators[NuSVC()-check_classifiers_train(readonly_memmap=True)] PASSED     [ 55%]
sklearn/tests/test_common.py::test_estimators[NuSVC()-check_classifiers_train(readonly_memmap=True,X_dtype=float32)] P$SSED [ 66%]
sklearn/tests/test_common.py::test_estimators[SVC()-check_classifiers_train] PASSED                             [ 77%]
sklearn/tests/test_common.py::test_estimators[SVC()-check_classifiers_train(readonly_memmap=True)] PASSED       [ 88%]
sklearn/tests/test_common.py::test_estimators[SVC()-check_classifiers_train(readonly_memmap=True,X_dtype=float32)] PAS$ED [100%]

adrinjalali
adrinjalali approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna trust you on that this is now working :D

@jjerphan
Copy link
Member

jjerphan commented Nov 18, 2021 •
edited
Loading

In this case, could we scope some time in the coming days to focus on joblib then?

Edit: I saw the notification for review and wanted to approve and merge but had no machine at hand to.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 18, 2021

In this case, could we scope some time in the coming days to focus on joblib then?

Sure but I have no idea how to fix the problem in joblib. Will have to sleep on it.

@ogrisel ogrisel merged commit 432ae47 into scikit-learn:main Nov 18, 2021
@ogrisel ogrisel deleted the fix-prescott_openblas-part-2 branch November 18, 2021 19:08
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Nov 22, 2021
@ogrisel @glemaitre
Follow-up fix for check_classifiers_train on prescott OpenBLAS (sciki…
7b7a81c 
…t-learn#21704)
@ogrisel ogrisel mentioned this pull request Nov 24, 2021
Merged
@thomasjpfan thomasjpfan mentioned this pull request Nov 24, 2021
Merged
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Nov 29, 2021
@ogrisel @glemaitre
Follow-up fix for check_classifiers_train on prescott OpenBLAS (sciki…
3eabdf0 
…t-learn#21704)
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@ogrisel @samronsin
Follow-up fix for check_classifiers_train on prescott OpenBLAS (sciki…
7028d5f 
…t-learn#21704)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
@ogrisel @glemaitre
Follow-up fix for check_classifiers_train on prescott OpenBLAS (sciki…
0148b69 
…t-learn#21704)
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
@ogrisel @glemaitre
Follow-up fix for check_classifiers_train on prescott OpenBLAS (#21704)
aad3f99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@jjerphan jjerphan Awaiting requested review from jjerphan

Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @jjerphan @adrinjalali