fix skip unnecessary check of gram_matrix in coordinate_descent #22008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derHeinzer can you add a test to better understand what you fix? |
|
Hi, I encounter the same problem as #21997, thus I curious when this fix could be published? Thanks. |
|
This is a problem still using LassoCV w/ float32 data, would appreciate this getting into master! |
|
@jeremiedbb Thanks for the follow up! Unfortunately I ended up switching to float64 and changing how I sampled a while back to address the issue and no longer have the data needed to generate this issue (it was a very large dataset) |
|
I'm closing this PR since the issue it is supposed to fix has already been fixed, assuming this one is now unecessary. If not, an issue with some reproducible code will be welcome before reopening it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: Fixes #21997. See also #19004.