API Rename base_estimator in CalibratedClassifierCV #22054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkyyuvy
reviewed
Dec 22, 2021
glemaitre
reviewed
Dec 22, 2021
|
Hello @kevroi, are you still interested in working on PR? If so, there are review comments to be addressed from #22054 (review) |
glemaitre
approved these changes
May 19, 2022
thomasjpfan
reviewed
May 20, 2022
sklearn/calibration.py
Outdated
| "will be removed in 1.4.", | ||
| FutureWarning, | ||
| ) | ||
| self.estimator = self.base_estimator |
There was a problem hiding this comment.
This is usually an anti-pattern in scikit-learn. In this case, I think we we can get away with:
if self.base_estimator != "deprecated":
...
estimator = self.base_estimator
else:
estimator = self.estimator
# Estimator from now on
if estimator is None:
estimator = LinearSVC(random_state=0)
if self.cv == "prefit":
check_is_fitted(estimator, ...)WDYT @glemaitre ?
There was a problem hiding this comment.
I see what you mean. I think that you are right. Let me update it.
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
Co-authored-by: Kevin Roice <kevinroice@Kevins-Air.broadband> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
partly addresses #9104
What does this implement/fix? Explain your changes.
Renames
base_estimatortoestimatorsfor the CalibratedClassifierCV byrenaming in the
CalibratedClassifierCVand__CalibratedClassifierclasses