Skip to content

CI Use conda-forge's openmp in osx to build wheels #22109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Alternative #22105

What does this implement/fix? Explain your changes.

Uses libomp from conda-forge

@thomasjpfan thomasjpfan changed the title CI Use conda for openmp for osx [cd build] CI Use conda-forge for openmp for osx Jan 1, 2022
@thomasjpfan thomasjpfan changed the title CI Use conda-forge for openmp for osx CI Use conda-forge to get openmp in osx Jan 1, 2022
@thomasjpfan thomasjpfan changed the title CI Use conda-forge to get openmp in osx CI Use conda-forge to get openmp in osx to build wheels Jan 1, 2022
@thomasjpfan thomasjpfan changed the title CI Use conda-forge to get openmp in osx to build wheels CI Use conda-forge's openmp in osx to build wheels Jan 1, 2022
@thomasjpfan thomasjpfan changed the title CI Use conda-forge's openmp in osx to build wheels [NO MERGE] CI Use conda-forge's openmp in osx to build wheels Jan 1, 2022
@thomasjpfan thomasjpfan marked this pull request as ready for review January 1, 2022 17:27
@thomasjpfan thomasjpfan changed the title [NO MERGE] CI Use conda-forge's openmp in osx to build wheels CI Use conda-forge's openmp in osx to build wheels Jan 1, 2022
@thomasjpfan
Copy link
Member Author

The timeouts on i686 on linux is unrelated to the fixes for osx

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a stop gap solution.

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temporary workaround. Thanks @thomasjpfan !

At some point we'll need to dig into libomp to understand what's going wrong in versions > 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants