Skip to content

MNT Update black to stable version #22474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2022
Merged

MNT Update black to stable version #22474

merged 2 commits into from
Feb 15, 2022

Conversation

thomasjpfan
Copy link
Member

Now that black has a stable release, I think it is a good time to bump the black version.

I am starting to see some PRs use the latest version, which results in some non-related changes.

@glemaitre
Copy link
Member

I find it annoying that we don't have deterministic behaviour.

@jeremiedbb
Copy link
Member

I find it annoying that we don't have deterministic behaviour.

We knew that was a possibility when we decided to adopt black, the hope was that such changes would occur very rarely. It seem's like there was only a single change in between (the spaces around **) which I find reasonnable.

This being a stable release we can hope for even less changes in the future. They even guarantee no changes in a given year, and long term stability https://black.readthedocs.io/en/latest/the_black_code_style/index.html#stability-policy

@glemaitre
Copy link
Member

It seem's like there was only a single change in between (the spaces around **) which I find reasonable.

So we have a little chance to have PR in a merge conflict mode.

glemaitre
glemaitre reviewed Feb 15, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit 1fc86b6 into scikit-learn:main Feb 15, 2022
@thomasjpfan thomasjpfan mentioned this pull request Feb 15, 2022
Merged
@jeremiedbb jeremiedbb mentioned this pull request Feb 15, 2022
Merged
thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
@thomasjpfan
MNT Update black to stable version (scikit-learn#22474)
172d8c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @glemaitre @jeremiedbb