From 4d9c3ea0cceb2dbfc7b8ba0271eaed17dc567f39 Mon Sep 17 00:00:00 2001 From: Hao Chun Chang Date: Tue, 7 Jun 2022 22:43:02 +0800 Subject: [PATCH 1/2] Use global_random_seed in ensemble/test_base.py in _make_estimator --- sklearn/ensemble/tests/test_base.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sklearn/ensemble/tests/test_base.py b/sklearn/ensemble/tests/test_base.py index 46b638c179859..b512f841e023d 100644 --- a/sklearn/ensemble/tests/test_base.py +++ b/sklearn/ensemble/tests/test_base.py @@ -18,7 +18,7 @@ from sklearn.feature_selection import SelectFromModel -def test_base(): +def test_base(global_random_seed): # Check BaseEnsemble methods. ensemble = BaggingClassifier( base_estimator=Perceptron(random_state=None), n_estimators=3 @@ -29,7 +29,7 @@ def test_base(): ensemble.estimators_ = [] # empty the list and create estimators manually ensemble._make_estimator() - random_state = np.random.RandomState(3) + random_state = np.random.RandomState(global_random_seed) ensemble._make_estimator(random_state=random_state) ensemble._make_estimator(random_state=random_state) ensemble._make_estimator(append=False) From f215e3177a3d8c086a803feb0081321ad4ac85ca Mon Sep 17 00:00:00 2001 From: Hao Chun Chang Date: Tue, 7 Jun 2022 22:43:56 +0800 Subject: [PATCH 2/2] Add assertions for numpy int init bagging classifier --- sklearn/ensemble/tests/test_base.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sklearn/ensemble/tests/test_base.py b/sklearn/ensemble/tests/test_base.py index b512f841e023d..96374ba9811e0 100644 --- a/sklearn/ensemble/tests/test_base.py +++ b/sklearn/ensemble/tests/test_base.py @@ -47,6 +47,8 @@ def test_base(global_random_seed): base_estimator=Perceptron(), n_estimators=np.int32(3) ) np_int_ensemble.fit(iris.data, iris.target) + assert 3 == len(np_int_ensemble) + assert 3 == len(np_int_ensemble.estimators_) def test_base_zero_n_estimators():