Skip to content

MAINT Do not version *.pyc* #24081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Aug 2, 2022

What does this implement/fix? Explain your changes.

On development configurations, python byte-compiled files (i.e. *.pyc) can be suffix.
Currently, such suffixed files aren't ignore by git.

This add ignoration for them.

Any other comments?

Observed in #24077 (review).

@jjerphan jjerphan added the Quick Review For PRs that are quick to review label Aug 2, 2022
@glemaitre glemaitre merged commit 934c918 into scikit-learn:main Aug 2, 2022
@glemaitre
Copy link
Member

Thanks @jjerphan

@jjerphan jjerphan deleted the dev/ignore-pyc-glob branch August 2, 2022 09:59
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants