Skip to content

MAINT Check pyproject toml is consistent with min_dependencies #25610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2023
+37 −1
Merged

MAINT Check pyproject toml is consistent with min_dependencies #25610

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66bc70f
MAINT Check pyproject toml is consistent with min_dependencies
thomasjpfan Feb 14, 2023
b27d998
CLN Make it clear that only SciPy and Cython are checked
thomasjpfan Feb 14, 2023
6a7ca3e
Merge remote-tracking branch 'upstream/main' into pyproject_toml_meta…
thomasjpfan Feb 15, 2023
d4a7895
CLN Revert auto formatter
thomasjpfan Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion sklearn/tests/test_min_dependencies_readme.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Tests for the minimum dependencies in the README.rst file."""
"""Tests for the minimum dependencies in README.rst and pyproject.toml"""


import os
Expand Down Expand Up @@ -50,3 +50,39 @@ def test_min_dependencies_readme():
min_version = parse_version(dependent_packages[package][0])

assert version == min_version, f"{package} has a mismatched version"


def test_min_dependencies_pyproject_toml():
"""Check versions in pyproject.toml is consistent with _min_dependencies."""
# tomllib is available in Python 3.11
tomllib = pytest.importorskip("tomllib")

root_directory = Path(sklearn.__path__[0]).parent
pyproject_toml_path = root_directory / "pyproject.toml"

if not pyproject_toml_path.exists():
# Skip the test if the pyproject.toml file is not available.
# For instance, when installing scikit-learn from wheels
pytest.skip("pyproject.toml is not available.")

with pyproject_toml_path.open("rb") as f:
pyproject_toml = tomllib.load(f)

build_requirements = pyproject_toml["build-system"]["requires"]

pyproject_build_min_versions = {}
for requirement in build_requirements:
if ">=" in requirement:
package, version = requirement.split(">=")
package = package.lower()
pyproject_build_min_versions[package] = version

# Only scipy and cython are listed in pyproject.toml
# NumPy is more complex using oldest-supported-numpy.
assert set(["scipy", "cython"]) == set(pyproject_build_min_versions)

for package, version in pyproject_build_min_versions.items():
version = parse_version(version)
expected_min_version = parse_version(dependent_packages[package][0])

assert version == expected_min_version, f"{package} has a mismatched version"