From c5c7d7d5e257a0e8191216740bb4c29133bed5ce Mon Sep 17 00:00:00 2001 From: Maren Westermann Date: Sat, 1 Apr 2023 15:48:32 +0200 Subject: [PATCH 1/2] test-rcv1 [all random seeds] test_fetch_rcv1 --- sklearn/datasets/tests/test_rcv1.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sklearn/datasets/tests/test_rcv1.py b/sklearn/datasets/tests/test_rcv1.py index ac5c29e19cd25..89ecbb5a82121 100644 --- a/sklearn/datasets/tests/test_rcv1.py +++ b/sklearn/datasets/tests/test_rcv1.py @@ -10,7 +10,7 @@ from sklearn.utils._testing import assert_array_equal -def test_fetch_rcv1(fetch_rcv1_fxt): +def test_fetch_rcv1(fetch_rcv1_fxt, global_random_seed): data1 = fetch_rcv1_fxt(shuffle=False) X1, Y1 = data1.data, data1.target cat_list, s1 = data1.target_names.tolist(), data1.sample_id @@ -42,7 +42,7 @@ def test_fetch_rcv1(fetch_rcv1_fxt): assert num == Y1[:, j].data.size # test shuffling and subset - data2 = fetch_rcv1_fxt(shuffle=True, subset="train", random_state=77) + data2 = fetch_rcv1_fxt(shuffle=True, subset="train", random_state=global_random_seed) X2, Y2 = data2.data, data2.target s2 = data2.sample_id From 63e6fafb5bc70351b201cfe0c76101fb7b581601 Mon Sep 17 00:00:00 2001 From: Maren Westermann Date: Sat, 1 Apr 2023 16:16:49 +0200 Subject: [PATCH 2/2] fix linting [all random seeds] test_fetch_rcv1 --- sklearn/datasets/tests/test_rcv1.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sklearn/datasets/tests/test_rcv1.py b/sklearn/datasets/tests/test_rcv1.py index 89ecbb5a82121..11d0335f4fb8c 100644 --- a/sklearn/datasets/tests/test_rcv1.py +++ b/sklearn/datasets/tests/test_rcv1.py @@ -42,7 +42,9 @@ def test_fetch_rcv1(fetch_rcv1_fxt, global_random_seed): assert num == Y1[:, j].data.size # test shuffling and subset - data2 = fetch_rcv1_fxt(shuffle=True, subset="train", random_state=global_random_seed) + data2 = fetch_rcv1_fxt( + shuffle=True, subset="train", random_state=global_random_seed + ) X2, Y2 = data2.data, data2.target s2 = data2.sample_id