-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Use Scientific Python Plausible instance for stable doc analytics #26160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this is fine. Two questions from an operations point of view:
I'd propose merging this in the European morning as that is presumably when the load is lowest, and we have a whole EU day + US day to watch it. |
Reverting this PR seems like the easy fix if indeed things go badly. @stefanv seemed to say #25547 (comment) that even if the analytics server goes down, it will not prevent scikit-learn.org to load. IIUC that means that at worst we will not have any analytics data for Plausible for some period of time (potentially other projects will be affected too if the analytics server goes down completely not sure ...). @tupui in the Scientific Python Discord also indicated that the scikit-learn.org load is similar to the scipy.org and I scipy.org is already using the Scientific Python plausible instance. About communication with the Scientific Python people, I guess we can let @stefanv and @jarrodmillman (who can let us know if there are better contact people for this) when we plan to merge this. I am fine being pinged on a github issue (or Scientific Python Discord) if something goes bad and the best short-term fix is to revert this PR. |
@lesteve just FYI. As Stéfan indicated in the other issue/PR, there was an outage of the server at some point and I confirm that it did not impact at all the loading of the pages on SciPy (I actually only noticed the outage as I wanted to get some metrics 😅). You could also test that locally by pointing to a random URL. |
If you ping me on the Scientific Python discord before merging, I am happy to monitor the roll-out. |
Do you want to propose a datetime @lesteve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I confirm it works:
- I clicked a few times on a specific rendered pages:
https://output.circle-artifacts.com/output/job/9c160e45-7640-4f5a-8540-a5b1ef35d3f7/artifacts/0/doc/auto_examples/inspection/plot_causal_interpretation.html#sphx-glr-auto-examples-inspection-plot-causal-interpretation-py - and then I could see those clicks live in:
https://views.scientific-python.org/scikit-learn.org?page=%2Foutput%2Fjob%2F9c160e45-7640-4f5a-8540-a5b1ef35d3f7%2Fartifacts%2F0%2Fdoc%2Fauto_examples%2Finspection%2Fplot_causal_interpretation.html
I let you decide with @stefanv on discord on the time to merge this. Maybe early afternoon in Europe (e.g. today is good)? But I am not sure if @stefanv will be online.
OK I have contacted Stefan by Discord and will let you know. I would say if today does not work, it is probably better to postpone until next week to avoid making such a change on a Friday 😉. |
Keeping an eye on the server; thanks for coordinating! |
So Plausible has been on for ~8 hours on scikit-learn.org/stable, everything seems to work 🎉. Last time I heard from Stefan the Plausible server seemed to behave just fine. |
Reference Issues/PRs
This is a backport of #25547 targetting the
1.2.X
branch.What does this implement/fix? Explain your changes.
This adds the Scientific Python Plausible instance. A quick comparison on the dev doc seems to indicate Google Analytics and Plausible are in the same ball park see #25547 (comment).