Skip to content

DOC search link to sphinx version #26610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented Jun 18, 2023

Reference Issues/PRs

Fixes #26598.

What does this implement/fix? Explain your changes.

The github search link on the bottom of this section is broken. This PR currently uses

image

Alternatively we may use

image

or any other link that maintainers prefer.

@Charlie-XIAO Charlie-XIAO marked this pull request as ready for review June 18, 2023 15:42
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan merged commit f31d167 into scikit-learn:main Jun 19, 2023
@Charlie-XIAO Charlie-XIAO deleted the doc-sphinx-ver-search branch June 28, 2023 05:40
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jun 29, 2023
jeremiedbb pushed a commit that referenced this pull request Jun 29, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC Link in warning about doc build with Sphinx versions outdated
2 participants