Skip to content

DOC Add links to text/plot_hashing_vs_dict_vectorizer.py example #26967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Tialo
Copy link
Contributor

@Tialo Tialo commented Aug 1, 2023

Reference Issues/PRs

This adds links to text/plot_hashing_vs_dict_vectorizer.py examples as mentioned in #26927

What does this implement/fix? Explain your changes.

Any other comments?

Reference to this example was added to every feature extractor used in example file. If references in some classes are excessive I can delete them.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d8e0d35. Link to the linter CI: here

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if TfidfVectorizer and Transformer both need the link. WDYT @glemaitre

@glemaitre
Copy link
Member

I would not link the example to the TdfidfTransformer and only keep it for all vectorizers. It is relevant for all of them.

@Tialo Tialo force-pushed the docs/add-vectorizers-example-links branch from 98f0f98 to d8e0d35 Compare August 12, 2023 14:13
@adrinjalali adrinjalali merged commit 8eef0e7 into scikit-learn:main Aug 24, 2023
@Tialo Tialo deleted the docs/add-vectorizers-example-links branch August 24, 2023 13:30
akaashpatelmns pushed a commit to akaashp2000/scikit-learn that referenced this pull request Aug 25, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 29, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants