MNT replace Cython loss functions in SGD part 1 #27999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e65ed41 to
df4bdca
Compare
|
Can you write a high level summary of your three PRs in an issue? I'm guessing you are waiting for Technically, we can make the switch over to the |
jjerphan
reviewed
Jan 9, 2024
jjerphan
approved these changes
Jan 10, 2024
OmarManzoor
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #15123.
What does this implement/fix? Explain your changes.
This PR merely changes the order of Cython arguments to align with the ones in the
sklearn._lossmodule.Any other comments?
Note that
SGDClassifierandSGDOneClassSVMhave an attributeloss_function_that exposes the Cython extension type. Those attributes are depcrecated as of 1.4, see #27979.This PR does not change the Python API of those
loss_function_, only the Cython arguments which I would argue, are not part of the Python API.