DOC fix align table in API doc page #28600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasjpfan do you know a way in CSS in which we could center the table containing the sponsor logos without breaking other stuff, meaning the following table:
|
|
Actually @Charlie-XIAO also seems to know a lot more CSS than I do :) |
|
If we only want to center this particular one, it seems this table has a specific class div.sk-sponsor-div-box table.sk-sponsor-table {
display: table;
}will work (the |
|
Apparently, I did not try all the |
thomasjpfan
approved these changes
Mar 8, 2024
Charlie-XIAO
approved these changes
Mar 9, 2024
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Mar 14, 2024
thomasjpfan
pushed a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #28417, I made a change and remove
display: block;but apparently it has a detrimental effect on the API pages.I'm reverting this change. However, we need to come with a fix to center the table in the about page.