Skip to content

DOC [PST] fix styling/simplify structure of testimonial and about pages #28623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented Mar 13, 2024

Please note that this PR targets the new_web_theme branch!

Towards #28084. This is mainly to fix the styling of testimonial and about pages. Previously #28270 so pinging @adrinjalali and @glemaitre who reviewed that PR. It is essentially the same as #28270 except that it uses sphinx-design components to simplify the code. Rendered docs: about, testimonials.

Some thoughts: should we remove the secondary sidebar on the testimonials page?

Copy link

github-actions bot commented Mar 13, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2afdfc1. Link to the linter CI: here

@glemaitre glemaitre self-requested a review May 16, 2024 11:09
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering looks good. I think that we need to make pass on the different section to decide whether or not to remove some of the left or right side navbar.

@glemaitre glemaitre merged commit b548b7c into scikit-learn:new_web_theme May 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants