MNT bump to Cython=3.0.10 #28743
Merged
MNT bump to Cython=3.0.10 #28743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI in #28638 seems to confirm that bumping Cython to 3.0.10 fixes the windows crash. |
ogrisel
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
LGTM. Once colesbury/nogil-wheels#8 is merged we should also manually update our nogil CI environment as well.
betatim
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Similar to #28640, trying to fix CI of #28638.
What does this implement/fix? Explain your changes.
Updates min required version of cython to 3.0.10.
Any other comments?
Cython 3.10 includes cython/cython#6104 which might fix an error in the CI on windows for #28638.