MNT remove author and license in GLM files #28799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Apr 10, 2024
# Authors: The scikit-learn developers # License: BSD 3 clause
|
I think I'm missing something, did we decide on the standard header? |
See discussion in #20813 (comment). |
|
@thomasjpfan WDYT? |
|
My big concern is still #20813 (comment) I like the end goal of having a simplified header, but I feel uneasy about removing the authors. |
thomasjpfan
reviewed
May 3, 2024
| @@ -1,3 +1,5 @@ | |||
| # Authors: The scikit-learn developers | |||
| # License: BSD 3 clause | |||
There was a problem hiding this comment.
I think going with this suggestion makes sense: #20813 (comment)
Suggested change
| # License: BSD 3 clause | |
| # SPDX-License-Identifier: BSD-3-Clause |
There was a problem hiding this comment.
I don't mind, then we can update the blog for this as well.
thomasjpfan
approved these changes
May 11, 2024
adrinjalali
approved these changes
May 13, 2024
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
May 20, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #20813.
What does this implement/fix? Explain your changes.
I best start with my own authorship and remove all those info from GLMs.
Any other comments?
An alternative #20813 (comment) to removing is