DOC Update warm start example in ensemble user guide #28998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
May 13, 2024
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
May 20, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
The warm start example in ensemble.rst is a continuation from the regression example above. The regression example is now hidden in a dropdown, so its not immediately obvious what
estis and thatn_estimatorswas initially set to 100. Also even when the regression section is expanded, the code example is not immediately above (there is a plot).This section is also linked to in docstrings (#24579) so some users are sent directly here, without reading above.
This copies the regression example to the start, so the code block is runnable in isolation.
There is now a bit of repetition, but couldn't think of a better solution, happy to change though.
Any other comments?