CI Don't run CUDA workflow on closed/merged PRs #29448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a PR has been merged or closed we do not really need the results of this workflow and it costs money to run it.
|
In #29376 (comment) @ogrisel suggests that we don't need this PR. Can you explain the idea behind "regression on (only saw that comment after opening this) |
|
I would say YAGNI, the CUDA CI seems to be working fine, let's close this one and reopen if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a PR has been merged or closed we do not really need the results of this workflow and it costs money to run it.
I think it makes sense to add this restriction, but maybe it isn't worth it? What do others think?
This is a follow up to #29376