BLD Adds runtime lincense to wheels #29861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like everything works. The only failing issue is https://github.com/scikit-learn/scikit-learn/actions/runs/10886304161/job/30205993553?pr=29861 because it could not find a 3.13t wheel. |
|
What do we do about the "no 3.13t wheels for pandas" problem? Otherwise it would be nice to merge this before we all forget about it? |
lorentzenchr
approved these changes
Oct 7, 2024
It's been resolved now. There are 3.13t wheels for pandas now. |
betatim
approved these changes
Oct 9, 2024
BenJourdan
pushed a commit
to gregoryschwartzman/scikit-learn
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #27559 (comment)
What does this implement/fix? Explain your changes.
With this PR, the licenses from our runtime libraries are bundled in with our licenses in the wheels.