Skip to content

FIX check_transformer_data_not_an_array for ColumnTransformer #29938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2024
Merged

FIX check_transformer_data_not_an_array for ColumnTransformer #29938

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61d60b7
fix-test check_transformer_data_not_an_array
mrastgoo Sep 27, 2024
0cf8a05
update
mrastgoo Sep 27, 2024
fdc6206
Merge branch 'check_estimator_empty_data_messages' into check_transfo…
mrastgoo Sep 27, 2024
8e95296
Merge branch 'main' into check_transformer_notanarray_fixme
mrastgoo Sep 27, 2024
1b54949
formating linter
mrastgoo Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sklearn/compose/_column_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,7 +1327,6 @@ def __sklearn_tags__(self):
"check_estimators_nan_inf": "FIXME",
"check_estimator_sparse_array": "FIXME",
"check_estimator_sparse_matrix": "FIXME",
"check_transformer_data_not_an_array": "FIXME",
"check_fit1d": "FIXME",
"check_fit2d_predict1d": "FIXME",
"check_complex_data": "FIXME",
Expand All @@ -1338,7 +1337,11 @@ def __sklearn_tags__(self):

def _check_X(X):
"""Use check_array only when necessary, e.g. on lists and other non-array-likes."""
if hasattr(X, "__array__") or hasattr(X, "__dataframe__") or sparse.issparse(X):
if (
(hasattr(X, "__array__") and hasattr(X, "shape"))
or hasattr(X, "__dataframe__")
or sparse.issparse(X)
):
return X
return check_array(X, ensure_all_finite="allow-nan", dtype=object)

Expand Down