Skip to content

🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 #30021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 #30021

wants to merge 1 commit into from

Conversation

scikit-learn-bot
Copy link
Contributor

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

@scikit-learn-bot scikit-learn-bot force-pushed the auto-update-lock-files-main branch from 95e5714 to 2ff9b14 Compare October 7, 2024 05:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2ff9b14. Link to the linter CI: here

@lesteve
Copy link
Member

lesteve commented Oct 7, 2024

array-API related, likely due to array-api-compat 1.8 -> 1.9?

___________________ test_get_namespace_ndarray_with_dispatch ___________________

    @skip_if_array_api_compat_not_configured
    def test_get_namespace_ndarray_with_dispatch():
        """Test get_namespace on NumPy ndarrays."""
        array_api_compat = pytest.importorskip("array_api_compat")
    
        X_np = numpy.asarray([[1, 2, 3]])
    
        with config_context(array_api_dispatch=True):
            xp_out, is_array_api_compliant = get_namespace(X_np)
            assert is_array_api_compliant
            if np_version >= parse_version("2.0.0"):
                # NumPy 2.0+ is an array API compliant library.
>               assert xp_out is numpy
E               AssertionError: assert <module 'array_api_compat.numpy' from '/usr/share/miniconda/envs/testvenv/lib/python3.11/site-packages/array_api_compat/numpy/__init__.py'> is numpy

X_np       = array([[1, 2, 3]])
array_api_compat = <module 'array_api_compat' from '/usr/share/miniconda/envs/testvenv/lib/python3.11/site-packages/array_api_compat/__init__.py'>
is_array_api_compliant = True
xp_out     = <module 'array_api_compat.numpy' from '/usr/share/miniconda/envs/testvenv/lib/python3.11/site-packages/array_api_compat/numpy/__init__.py'>

/usr/share/miniconda/envs/testvenv/lib/python3.11/site-packages/sklearn/utils/tests/test_array_api.py:73: AssertionError

@glemaitre
Copy link
Member

glemaitre commented Oct 7, 2024 •
edited
Loading

Uhm I merged #30020 where the CI don't fail with the bumping. I would have expected the test to fail also there.

@lesteve
Copy link
Member

lesteve commented Oct 7, 2024 •
edited
Loading

I think you did not unset + set "CUDA CI" label right? That means that the CUDA CI did not run in #30020.

I wanted to retrigger a lock-file update after I merged #29994 but too late 😅.

@glemaitre
Copy link
Member

glemaitre commented Oct 7, 2024 •
edited
Loading

Nop I did not unset/set and indeed I we did not run the CI. So it is broken as well :)

@glemaitre
Copy link
Member

So the regression is not really a regression: because NumPy 2.+ is actually not yet array-API compliant, then the namespace was reverted to the array_api_compat wrapper: data-apis/array-api-compat#170

I assume the best for now would be to skip the test for older version of array-api-compat and check that the wrapper is used.

@glemaitre glemaitre self-requested a review October 7, 2024 17:11
@glemaitre glemaitre mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre Awaiting requested review from glemaitre

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scikit-learn-bot @lesteve @glemaitre @web-flow