Skip to content

🔒 CI Update lock files for main CI build(s) 🔒 #30026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

glemaitre
Copy link
Member

closes #30021

Amend the test checking for the NumPy namespace.
This change check that we are compatible with array-api-compat >= 1.9.

Copy link

github-actions bot commented Oct 7, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 459caba. Link to the linter CI: here

@@ -62,18 +62,21 @@ def test_get_namespace_ndarray_creation_device():
def test_get_namespace_ndarray_with_dispatch():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogrisel @lesteve this is the main change to be compatible with the new array-api-compat release.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Here is the upstream PR for reference: data-apis/array-api-compat#170

@ogrisel ogrisel merged commit df07b99 into scikit-learn:main Oct 8, 2024
38 of 41 checks passed
BenJourdan pushed a commit to gregoryschwartzman/scikit-learn that referenced this pull request Oct 11, 2024
Co-authored-by: Lock file bot <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants