Skip to content

DOC: RandomForestClassifier depends on DecisionTreeClassifier, not DecsionTreeRegressor #30035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hhchen1105
Copy link
Contributor

What does this implement/fix? Explain your changes.

The document incorrectly states ``Trees in the forest use the best split strategy, i.e. equivalent to passing splitter="best" to the underlying DecisionTreeRegressor'', which should be DecisionTreeClassifier.

Copy link

github-actions bot commented Oct 9, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 226704a. Link to the linter CI: here

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this point.

@glemaitre glemaitre merged commit fbb32ea into scikit-learn:main Oct 9, 2024
33 checks passed
@hhchen1105 hhchen1105 deleted the RandomForestClassifer-doc-problem branch October 10, 2024 01:54
BenJourdan pushed a commit to gregoryschwartzman/scikit-learn that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants