From f50f2600c4179aea7329efd1b94a0d2a274e21ef Mon Sep 17 00:00:00 2001 From: Marie Date: Wed, 30 Oct 2024 14:59:57 +0100 Subject: [PATCH 1/4] doc(contributing): update contributing to orient toward gh and discord instead of mailing list --- doc/developers/contributing.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/developers/contributing.rst b/doc/developers/contributing.rst index 228253f112b3d..2638d20975db6 100644 --- a/doc/developers/contributing.rst +++ b/doc/developers/contributing.rst @@ -51,7 +51,7 @@ There are many ways to contribute to scikit-learn, with the most common ones being contribution of code or documentation to the project. Improving the documentation is no less important than improving the library itself. If you find a typo in the documentation, or have made improvements, do not hesitate to -send an email to the mailing list or preferably submit a GitHub pull request. +create a GitHub issue or preferably submit a GitHub pull request. Full documentation can be found under the doc/ directory. But there are many other ways to help. In particular helping to @@ -345,8 +345,9 @@ The next steps now describe the process of modifying code and submitting a PR: 12. Follow `these `_ instructions to create a pull request from your fork. This will send an - email to the committers. You may want to consider sending an email to the - mailing list for more visibility. + email to the committers. You may want to consider sending an message to + the `discord `_ in the development + chanel for more visibility (instant replies are not guaranteed). It is often helpful to keep your local feature branch synchronized with the latest changes of the main scikit-learn repository: From cd9c1d02d1d7c3bc46f69e0668087cad768a4f29 Mon Sep 17 00:00:00 2001 From: MarieS-WiMLDS <79304610+MarieS-WiMLDS@users.noreply.github.com> Date: Wed, 30 Oct 2024 16:15:32 +0100 Subject: [PATCH 2/4] Update doc/developers/contributing.rst Co-authored-by: Guillaume Lemaitre --- doc/developers/contributing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/developers/contributing.rst b/doc/developers/contributing.rst index 2638d20975db6..62f008413a8f8 100644 --- a/doc/developers/contributing.rst +++ b/doc/developers/contributing.rst @@ -347,7 +347,7 @@ The next steps now describe the process of modifying code and submitting a PR: instructions to create a pull request from your fork. This will send an email to the committers. You may want to consider sending an message to the `discord `_ in the development - chanel for more visibility (instant replies are not guaranteed). + channel for more visibility (instant replies are not guaranteed). It is often helpful to keep your local feature branch synchronized with the latest changes of the main scikit-learn repository: From 126f21aad754d709dee11d8d05268581bef547f2 Mon Sep 17 00:00:00 2001 From: MarieS-WiMLDS <79304610+MarieS-WiMLDS@users.noreply.github.com> Date: Wed, 30 Oct 2024 16:29:11 +0100 Subject: [PATCH 3/4] Update doc/developers/contributing.rst Co-authored-by: Olivier Grisel --- doc/developers/contributing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/developers/contributing.rst b/doc/developers/contributing.rst index 62f008413a8f8..1a566fb488016 100644 --- a/doc/developers/contributing.rst +++ b/doc/developers/contributing.rst @@ -345,7 +345,7 @@ The next steps now describe the process of modifying code and submitting a PR: 12. Follow `these `_ instructions to create a pull request from your fork. This will send an - email to the committers. You may want to consider sending an message to + notification to potential reviewers. You may want to consider sending an message to the `discord `_ in the development channel for more visibility (instant replies are not guaranteed). From e8c920714b49aee47fe9a3d9bbac1cc11c954f86 Mon Sep 17 00:00:00 2001 From: MarieS-WiMLDS <79304610+MarieS-WiMLDS@users.noreply.github.com> Date: Wed, 30 Oct 2024 16:29:23 +0100 Subject: [PATCH 4/4] Update doc/developers/contributing.rst Co-authored-by: Olivier Grisel --- doc/developers/contributing.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/developers/contributing.rst b/doc/developers/contributing.rst index 1a566fb488016..129325e275963 100644 --- a/doc/developers/contributing.rst +++ b/doc/developers/contributing.rst @@ -347,7 +347,8 @@ The next steps now describe the process of modifying code and submitting a PR: instructions to create a pull request from your fork. This will send an notification to potential reviewers. You may want to consider sending an message to the `discord `_ in the development - channel for more visibility (instant replies are not guaranteed). + channel for more visibility if your pull request does not receive attention after + a couple of days (instant replies are not guaranteed though). It is often helpful to keep your local feature branch synchronized with the latest changes of the main scikit-learn repository: