Skip to content

DOC Add link for prediction latency plot for classification benchmark #30462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

DOC Add link for prediction latency plot for classification benchmark #30462

wants to merge 7 commits into from
+4 −0

Conversation

kayo09
Copy link

@kayo09 kayo09 commented Dec 11, 2024 •
edited
Loading

Towards #26927

Add example link documentation for ploting benchmarks for forest covertype dataset

edit: thank you @StefanieSenger :)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d5af721. Link to the linter CI: here

@kayo09 kayo09 changed the title DOC Add link for prediction latency plot DOC Add link for prediction latency plot for classification benchmark Dec 11, 2024
@StefanieSenger
Copy link
Contributor

StefanieSenger commented Dec 16, 2024 •
edited
Loading

Hi @kayo09,

I see you are trying to make your first contribution to scikit-learn in our meta issue for adding links to the documentation. Two things:

  1. Your suggestion unfortunately does not add the links to the docs build with sphinx. Please refer to these tipps to learn what this issue tries to archive and push again to this branch.

  2. Please do not write "Fix: 26927" in the PR description, because his leads to automatically closing our issue when your PR would be merged. Use something like "Towards 26927" instead.

@kayo09 kayo09 marked this pull request as draft December 16, 2024 09:29
@StefanieSenger StefanieSenger mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation module:datasets Stalled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayo09 @StefanieSenger