Skip to content

CI Work around the lack of Windows free-threaded wheel for pandas #31159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

CI Work around the lack of Windows free-threaded wheel for pandas #31159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21291b2
CI Use released versions for non Windows free-threaded wheels
lesteve Apr 7, 2025
8d49db6
[cd build]
lesteve Apr 7, 2025
8ac5cd7
[cd build] do not install pandas for Windows free-threaded
lesteve Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ jobs:
CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: bash build_tools/github/repair_windows_wheels.sh {wheel} {dest_dir}
CIBW_BEFORE_BUILD: bash {project}/build_tools/wheels/cibw_before_build.sh {project}
CIBW_BEFORE_TEST_WINDOWS: bash build_tools/github/build_minimal_windows_image.sh ${{ matrix.python }}
CIBW_BEFORE_TEST: bash {project}/build_tools/wheels/cibw_before_test.sh
CIBW_ENVIRONMENT_PASS_LINUX: RUNNER_OS
CIBW_TEST_REQUIRES: pytest pandas
# On Windows, we use a custom Docker image and CIBW_TEST_REQUIRES_WINDOWS
Expand Down
10 changes: 4 additions & 6 deletions build_tools/github/build_minimal_windows_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,8 @@ if [[ $FREE_THREADED_BUILD == "False" ]]; then
docker commit $CONTAINER_ID scikit-learn/minimal-windows
else
# This is too cumbersome to use a Docker image in the free-threaded case
# TODO Remove the next three lines when scipy and pandas each have a release
# with a Windows free-threaded wheel.
python -m pip install numpy
dev_anaconda_url=https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
python -m pip install --pre --upgrade --timeout=60 --extra-index $dev_anaconda_url scipy pandas --only-binary :all:
python -m pip install $CIBW_TEST_REQUIRES
# TODO When pandas has a release with a Windows free-threaded wheel we can
# replace the next line with
# python -m pip install CIBW_TEST_REQUIRES
python -m pip install pytest
fi
13 changes: 0 additions & 13 deletions build_tools/wheels/cibw_before_test.sh
View file
Open in desktop

This file was deleted.

Loading