Skip to content

FIX Use sample weight to draw samples in Bagging estimators #31165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

FIX Use sample weight to draw samples in Bagging estimators #31165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
df282ad
use sample weight for sampling
antoinebaker Apr 9, 2025
ecf3bcf
fix call in IsolationForest
antoinebaker Apr 9, 2025
1b63920
changelog
antoinebaker Apr 9, 2025
084f64d
validate sample weight
antoinebaker Apr 9, 2025
db1c1e8
harmonize kwargs order
antoinebaker Apr 9, 2025
85c7e8c
add more samples
antoinebaker Apr 9, 2025
df49db3
oops forgot print statements
antoinebaker Apr 9, 2025
7863d5e
doc
antoinebaker Apr 10, 2025
75afc73
doc
antoinebaker Apr 10, 2025
6a1af69
Update doc/whats_new/upcoming_changes/sklearn.ensemble/31165.fix.rst
antoinebaker Apr 11, 2025
55ce891
Update doc/whats_new/upcoming_changes/sklearn.ensemble/31165.fix.rst
antoinebaker Apr 11, 2025
1de2b07
Update sklearn/ensemble/_bagging.py
antoinebaker Apr 16, 2025
29c1944
fix test metadata
antoinebaker Apr 16, 2025
c4541fd
add warnings
antoinebaker Apr 16, 2025
58c70ba
Merge remote-tracking branch 'upstream/main' into bagging_sample_weight
antoinebaker Apr 17, 2025
a8368bd
fix doctest
antoinebaker Apr 17, 2025
b118ffe
renaming
antoinebaker Apr 22, 2025
bf6977d
define sampling_strategy
antoinebaker May 21, 2025
7f425fb
Merge remote-tracking branch 'upstream/main' into bagging_sample_weight
antoinebaker May 21, 2025
575a6bd
bullet list ident
antoinebaker May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/whats_new/upcoming_changes/sklearn.ensemble/31165.fix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- :class:`ensemble.BaggingClassfier`, :class:`ensemble.BaggingRegressor`
and :class:`ensemble.IsolationForest` now use `sample_weight` to draw
the samples instead of forwarding them to the underlying estimators.
By :user:`Antoine Baker <antoinebaker>`.
Loading