Skip to content

DOC Fix plotly rendering inside JupyterLite #31400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented May 20, 2025

Fix #31399.

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 663f256. Link to the linter CI: here

@lesteve
Copy link
Member Author

lesteve commented May 20, 2025

Seems to work fine AFAICT. Here is the link to JupyterLite notebook in this PR build

cc @ArturoAmorQ

Side-comment: because of a joblib bug in the latest release joblib/joblib#1720, we don't have a Pyodide dev wheel and you need to comment out these lines currently

await piplite.install(
 'scikit-learn==1.8.dev0',
  index_urls='https://pypi.anaconda.org/scientific-python-nightly-wheels/simple',
)

Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work as intended, thanks @lesteve!

@ArturoAmorQ ArturoAmorQ merged commit 19a6e61 into scikit-learn:main May 20, 2025
39 checks passed
@lesteve lesteve deleted the jupyterlite-nbformat branch May 20, 2025 14:20
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC Jupyterlite raises a ValueError when using plotly
2 participants