Skip to content

[WIP] Storing the best attributes of (non-GridSearch) CV models #5498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[WIP] Storing the best attributes of (non-GridSearch) CV models #5498

wants to merge 3 commits into from

Conversation

MechCoder
Copy link
Member

Continuation of work done by @eshillts .

@MechCoder MechCoder added Easy Well-defined and straightforward way to resolve Need Contributor labels Oct 20, 2015
@MechCoder
Copy link
Member Author

If anyone wants to work on this during the sprint, please let me know!

amueller
amueller reviewed Oct 21, 2015
View reviewed changes
sklearn/linear_model/least_angle.py
@@ -1338,6 +1359,15 @@ class LassoLarsIC(LassoLars):
alphas. The alpha which has the smallest information criteria
is chosen.

``best_score_`` : float
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need the ticks here any more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amueller More detail on this, please ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that Andreas Mueller should answer this but it seems what he meant is the ticks `` are not needed. It is to bold the text., but now it is done by default for the attributes. Hope it helps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maniteja123 , yeah. Made sense. thanks!

@amueller
Copy link
Member

Related #4667, maybe you can pick up #4790, too?

@MechCoder
Copy link
Member Author

If there are new contributors willing to pick this up during the sprint, it would be great. If it remains unaddressed then I'll fix it.

@raghavrv
Copy link
Member

@MechCoder Could I take this up??

@MechCoder
Copy link
Member Author

Please !

@Sentient07
Copy link
Contributor

@MechCoder @rvraghav93 Ping. Shall i take this up ?

@raghavrv
Copy link
Member

Please do :)

@Sentient07 Sentient07 mentioned this pull request Jan 23, 2016
Closed
@Sentient07
Copy link
Contributor

@rvraghav93 @MechCoder , A quick question, i've added this branch as my remote, made the changes and pushed it to my fork. Should i open a new PR ?

@raghavrv
Copy link
Member

I think you could cherry-pick the commits alone from this branch into your new branch (checked out from the current master), and fix merge conflicts if any (there will be actually there wont be any) and push and open a new PR :)

@Sentient07
Copy link
Contributor

@rvraghav93 I guess travis would still fail, haven't checked that. I'll make a new PR

@Sentient07 Sentient07 mentioned this pull request Jan 23, 2016
Closed
@MechCoder MechCoder closed this Jan 24, 2016
@MechCoder MechCoder deleted the best_attributes branch January 24, 2016 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MechCoder @amueller @raghavrv @Sentient07 @ogrisel @GaelVaroquaux @arjoly @maniteja123 @eshilts