Skip to content

[MRG+1] Doc: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in the title of the pull request. #7636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2016
Merged

[MRG+1] Doc: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in the title of the pull request. #7636

merged 1 commit into from
Oct 11, 2016

Conversation

aashil
Copy link
Contributor

@aashil aashil commented Oct 10, 2016 •
edited
Loading

Reference Issue

Fixes #7630

What does this implement/fix? Explain your changes.

  • This PR adds the instructions to explain the meaning of prefix [MRG + 1] and [MRG +2] in the PR title.

Any other comments?

  • File updated: doc/developers/contributing.rst

@aashil
dev-7360: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in th…
7f0c011 
…e title of the pull request.

* File updated: doc/developers/contributing.rst
@aashil aashil changed the title [MRG] Explain the meaning of prefix [MRG + 1] and [MRG + 2] in the title of the pull request. [MRG] Doc: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in the title of the pull request. Oct 10, 2016
@aashil
Copy link
Contributor Author

aashil commented Oct 11, 2016

@amueller @jnothman What is the reason for circleci tests to time out. Build output says command ./build_tools/circle/build_doc.sh took more than 10 minutes since last output Not sure why.

@jnothman
Copy link
Member

Succinct. LGTM

@jnothman jnothman changed the title [MRG] Doc: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in the title of the pull request. [MRG+1] Doc: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in the title of the pull request. Oct 11, 2016
@amueller
Copy link
Member

lgtm. thanks :)

@amueller amueller merged commit dd8a6fa into scikit-learn:master Oct 11, 2016
@amueller amueller mentioned this pull request Oct 13, 2016
Closed
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Oct 14, 2016
@aashil @amueller
dev-7360: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in th…
f0c803f 
…e title of the pull request. (scikit-learn#7636)

* File updated: doc/developers/contributing.rst
@aashil aashil mentioned this pull request Feb 19, 2017
Closed
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@aashil @Sundrique
dev-7360: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in th…
0076cd8 
…e title of the pull request. (scikit-learn#7636)

* File updated: doc/developers/contributing.rst
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@aashil @paulha
dev-7360: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in th…
13c8efa 
…e title of the pull request. (scikit-learn#7636)

* File updated: doc/developers/contributing.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contrib docs should mention +1 +2
3 participants
@aashil @jnothman @amueller