Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MRG+1] Support Vector Data Description #7910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[MRG+1] Support Vector Data Description #7910
Changes from all commits
eb2d93a
6d373a6
d86b3fd
766a344
4093763
941ca4b
e8cd614
543c4e6
d751148
ba11173
1a7083a
5472505
a959082
355c548
d765a40
bba31b6
71ecce1
8c60b69
fab4538
7082a56
dbbc90b
c13582d
90085e0
84a1dcb
3d39584
4d7217d
2654479
1e54626
7a0ede0
6bf0fb5
00f3279
0e015e0
6bb003f
fd43605
b0f4926
742954a
9c95eea
36778b4
4e5ca41
3cc3610
80a1725
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with this model. Is there something more specific that we could say to help the user choose between the two models when the kernel is not stationary?
For instance on the example we can see that for the polynomial kernel, the high density region is convex of SVDD-L1 is convex while it is not the case of the One-Class SVM model. Is this always the case? Or maybe under some assumption on the shape of the data?
It would be great to make the inductive bias of each model a bit more explicit if possible while not going into a deep mathematical comparison if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add OneClassSVM and SVDD in Kernel cache size above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add SVDD after OneClassSVM in Randomness of the underlying implementations? (the implemenations of OneClassSVM and SVDD are both not random)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as for the OCSVM: as the other implementations in the SVM module do not include the weights in the description of their formulation, maybe we should do the same here. But let's see what the others think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather update all the formulas to also include the weights. It cases where the formulas with the weights becomes too complex maybe one could mention the two formulas, the first without the weights (to get the gist of the loss function) and the second with the weights for the sake of completeness.